[1.18 Backport] gateway params externaltrafficpolicy #10552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-shelaga
changed the title
kevin-shelaga
changed the title
jenshu
reviewed
Jan 7, 2025
jenshu
reviewed
Jan 7, 2025
Co-authored-by: Jenny Shu <[email protected]>
|
Issues linked to changelog: |
…afficpolicy-1-18-backport
nfuden
changed the title
jenshu
reviewed
Jan 8, 2025
Co-authored-by: Jenny Shu <[email protected]>
…as being unset (#10559) Signed-off-by: Shashank Ram <[email protected]>
…afficpolicy-1-18-backport
jenshu
approved these changes
Jan 8, 2025
nfuden
approved these changes
Jan 8, 2025
soloio-bulldozer
bot
deleted the
gwp-externaltrafficpolicy-1-18-backport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v1.18 Backport
When using the Kubernetes Gateway API, the provisioned proxy service external traffic policy is now configurable via the GatewayParameters fields spec.kube.service.externalTrafficPolicy
This values can also be set on the default GatewayParameters during install/upgrade using the Helm value kubeGateway.gatewayParameters.glooGateway.service.externalTrafficPolicy
API changes
Added fields to GatewayParameters:
spec.kube.service.externalTrafficPolicy
Code changes
Update gw params to expose external traffic policy
Add test
Context
Fixes kgateway-dev#9879
Users need to be able to change the external traffic policy so that source client IPs are preserved for features like WAF and ext auth.
Testing steps
helm unit tests
deployer unit tests
deployer e2e test
Checklist:
BOT NOTES:
resolves Ability to set "externalTrafficPolicy" in "GatewayParameters" kgateway-dev/kgateway#9879